fix(Settings): add scroll only menu items, keep title and search fixed #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowely
requested review from
BlackPoretsky,
DarkGenius,
Lunory and
kendoow
as code owners
Nowely
changed the title
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
ogonkov
reviewed
Dec 23, 2025
|
|
||
| &__menu { | ||
| border-right: 1px solid var(--g-color-line-generic); | ||
| overflow-y: auto; |
Contributor
There was a problem hiding this comment.
This will scroll whole block, including search field, isn't it?
Collaborator
Author
There was a problem hiding this comment.
Yes, you're right. This behavior is similar to that of the __page.
Contributor
There was a problem hiding this comment.
I believe only items should have scroll, i think search form and header should remain on the screen
Collaborator
|
Please add a story with more elements in the settings to check the scrolling behavior. |
… overflow scenarios
Nowely
changed the title
Nowely
changed the title
added 3 commits
December 25, 2025 13:37
Nowely
force-pushed
the
fix-settings-overflow
branch
from
de3a369 to
05647e2
Compare
Collaborator
Author
|
@DarkGenius Pr can be reviewed |
DarkGenius
approved these changes
Jan 14, 2026
Nowely
added a commit
that referenced
this pull request
Jan 19, 2026
#531) * fix: add overflow-y property to settings menu for better scrolling behavior * feat: enhance settings layout with overflow handling and add demo for overflow scenarios * test: add visual snapshots and overflow test case for BurgerMenu component * test: update visual snapshots for BurgerMenu component to reflect recent changes * feat: add scrollable region focusable setting and enhance accessibility for settings items * feat: add scrolled state to SettingsMenu for enhanced visual feedback on scroll --------- Co-authored-by: Ilyin Ruslan <[email protected]>
Nowely
added a commit
that referenced
this pull request
Jan 19, 2026
#531) * fix: add overflow-y property to settings menu for better scrolling behavior * feat: enhance settings layout with overflow handling and add demo for overflow scenarios * test: add visual snapshots and overflow test case for BurgerMenu component * test: update visual snapshots for BurgerMenu component to reflect recent changes * feat: add scrollable region focusable setting and enhance accessibility for settings items * feat: add scrolled state to SettingsMenu for enhanced visual feedback on scroll --------- Co-authored-by: Ilyin Ruslan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Settings.module.scss: Made__menua flex column container withmin-height: 0to enable inner scrollSettingsMenu.module.scss: Addedoverflow-y: autoto scroll menu items independentlyOverflowstory to test scroll behavior with many menu items and page content